Explorar el Código

Fix circular list creation in dynamic update

Using nconc on results from a memoized function was a bad idea, since
obviously the memoized function could return the same object twice,
and (nconc x x) creates a circular list.

Fixes #151.
Ryan C. Thompson hace 7 años
padre
commit
6861547489
Se han modificado 1 ficheros con 1 adiciones y 1 borrados
  1. 1 1
      ido-completing-read+.el

+ 1 - 1
ido-completing-read+.el

@@ -916,7 +916,7 @@ This has no effect unless `ido-cr+-dynamic-collection' is non-nil."
                  (new-completions
                   (cl-loop
                    for string in strings-to-check
-                   nconc
+                   append
                    (funcall
                     (or ido-cr+-all-prefix-completions-memoized
                         'ido-cr+-all-prefix-completions)